search

Atlas-Authority / marketing-automation

GNU General Public License v3.0
19 stars 16 forks source link

Update whether fields are required or optional when parsing data from Marketplace #171

Closed boris-moduscreate closed 1 year ago

boris-moduscreate commented 1 year ago

See the API response docs at https://developer.atlassian.com/platform/marketplace/rest/v2/api-group-reporting/#api-vendors-vendorid-reporting-licenses-get-response which is technically a different API endpoint than what we use, but should match in behavior.

Google Chrome 2023-08-14 at 15 59 13

Then update whether the value is required or not required when we parse the data. This should help us avoid issues like https://github.com/Atlas-Authority/marketing-automation/issues/158

boris-moduscreate commented 1 year ago

@khanguyen88 even with #172, it looks like we're still failing when license.data.maintenanceEndDate is null.

khanguyen88 commented 1 year ago

I merged the missing part.