Error: Primary duplicate is accounted for twice: XXXXXXXXXXXX

[apwidejulien]

It seems a new "pattern" appeared recently in our marketplace reporting; several entries with same order id (transaction id):

For the provided example, we have:

• 1 for refund a previous transaction.
• 1 for upgrade + change billing period monthly to annual maintenance period on 2024
• 1 for renewal on annual maintenance period 2025.

This result raise an error in action generation:

Get action for event upgrade , Transaction ID: (AT)IN-EU-000-656-718[AEI-04a806ba-3b02-349e-a8c4-6d6cdc1c93c1]
Found duplicate deals. Pick single deal:  20358085480 , deals to delete: [ '20358085481' ]
Get action for event renewal , Transaction ID: (AT)IN-EU-000-656-718[AEI-04a806ba-3b02-349e-a8c4-6d6cdc1c93c1]
Found duplicate deals. Pick single deal:  20358085480 , deals to delete: [ '20358085481' ]
7/3/2024, 6:14:35 AM ERR! Runner Error:
7/3/2024, 6:14:35 AM ERR! Runner   Error: Primary duplicate is accounted for twice: 20358085480
7/3/2024, 6:14:35 AM ERR! Runner       at ActionGenerator.singleDeal (/usr/src/app/src/lib/deal-generator/actions.ts:210:15)
7/3/2024, 6:14:35 AM ERR! Runner       at ActionGenerator.actionForRenewal (/usr/src/app/src/lib/deal-generator/actions.ts:105:23)
7/3/2024, 6:14:35 AM ERR! Runner       at ActionGenerator.actionsFor (/usr/src/app/src/lib/deal-generator/actions.ts:46:36)
7/3/2024, 6:14:35 AM ERR! Runner       at /usr/src/app/src/lib/deal-generator/actions.ts:39:41
7/3/2024, 6:14:35 AM ERR! Runner       at Array.flatMap (<anonymous>)
7/3/2024, 6:14:35 AM ERR! Runner       at ActionGenerator.generateFrom (/usr/src/app/src/lib/deal-generator/actions.ts:39:19)
7/3/2024, 6:14:35 AM ERR! Runner       at DealGenerator.generateActionsForMatchedGroup (/usr/src/app/src/lib/deal-generator/deal-generator.ts:103:42)
7/3/2024, 6:14:35 AM ERR! Runner       at /usr/src/app/src/lib/deal-generator/deal-generator.ts:46:51
7/3/2024, 6:14:35 AM ERR! Runner       at withAutoClose (/usr/src/app/src/lib/util/helpers.ts:28:12)
7/3/2024, 6:14:35 AM ERR! Runner       at DealGenerator.run (/usr/src/app/src/lib/deal-generator/deal-generator.ts:42:25)

I would be more than happy to help with, but not sure how to deal with this:

• should it be handled the same way than refund during event generation and merging several entries for same order id with renewal/upgrade type on one event + sum the amount ?
• should it be handled on action generation to avoid duplicated error when processing several event with same transaction id, but how: updating an existing deal with the second transaction, or creating a new deal ?

Thanks in advance for your help!

[boris-moduscreate]

@nhan-nguyen-se any thoughts on this?

[nhan-nguyen-se]

The questions are about business logic which I have very little with this app. @apwidejulien Do we have a deduplication logic already? If so I think we can extend it to handle more duplication cases we found here.

[apwidejulien]

You probably have more knowledge about business logic with this app than me :smile:

To unblock the import, I ended with this crappy stuff: https://github.com/apwide/marketing-automation/commit/fd1ca73a8d56f10414466751aad73ac5ec84c3cd

If I understood correctly, except for refund, we make a hard assumption that we should have only 1 pair transactionId-licenseId which result in 1 deal into HubSpot. However, with our example, we can see this case can happen. I have the feeling Atlassian recently changed the cardinality of the transactions export to not returning transaction, but transaction lines... (a new column appeared in the mkp export named transactionLineItemId )

What I did was just suffixing the transactionId with transactionLineItemId for the duplicates after having sorted them by maintenance date, so deals should be created for each transactionId, but the problem should probably be fixed in the core to map deal using pair license/txId/txLineId.

[boris-moduscreate]

Hmm ok I think that makes sense @apwidejulien Any chance you can help with the core changes?