[FEATURE] - Notifications should not be disabled by default

Atlas-OS / Atlas

🚀 An open and lightweight modification to Windows, designed to optimize performance, privacy and usability.

https://atlasos.net

GNU General Public License v3.0

13.55k stars 518 forks source link

[FEATURE] - Notifications should not be disabled by default #1100

Open ghost opened 4 months ago

ghost commented 4 months ago

What is your feature request regarding to?

Atlas Playbook

Is your feature request related to a problem? Please describe.

Currently, by default, Atlas completely disables notifications. I think that this is an unintuitive default, and that something as important as notifications should be untouched, and left up to the user to configure.

Describe the solution you would like.

Keep notifications enabled by default

Describe alternatives you have considered.

n/a

Additional context.

No response

trolljoe commented 4 months ago

doesn't it ask you if you wanna disable it or not in the playbook?

ghost commented 4 months ago

Yeah i guess i missed that. I still think it should be opt-in in the installer though, not enabled by default.

Ast3risk-ops commented 4 months ago

What are you even saying, it is opt-in. (https://github.com/Atlas-OS/Atlas/blob/main/src/playbook/playbook.conf#L111-L116)

ghost commented 4 months ago

First of all, "What are you even saying" is not the nicest way to respond to someone. Second, let me clarify what I mean: when you go through the Atlas installer, disable notifications is on by default. Of course you can just turn it off, but I think that disabling notifications is quite extreme, and shouldn't be opt-out, as it's quite easy to gloss over, as I just did here.

he3als commented 4 months ago

What are you even saying, it is opt-in. (https://github.com/Atlas-OS/Atlas/blob/main/src/playbook/playbook.conf#L111-L116)

Please don't be rude

Xyueta commented 4 months ago

First of all, "What are you even saying" is not the nicest way to respond to someone. Second, let me clarify what I mean: when you go through the Atlas installer, disable notifications is on by default. Of course you can just turn it off, but I think that disabling notifications is quite extreme, and shouldn't be opt-out, as it's quite easy to gloss over, as I just did here.

This is due to a poll that has been conducted on our discord server. As mentioned, you have the ability to turn them on or off (customization) within the AME Wizard configuration part.

Thanks.

he3als commented 4 months ago

In that poll, it wasn't noted that turning off the notification service was unlikely to improve performance. However, even if we go with the poll results, the security implications need to be factored in, as users who turn off auto-updates are meant to get notifications for updates via Windows notifications.

he3als commented 4 months ago

Options are being refactored in #1111