search

Atlas-Rhythm / Hive

A general backend project for modding communities.
GNU Affero General Public License v3.0
11 stars 1 forks source link

fix: dockerfile #118

Closed luludotdev closed 1 year ago

luludotdev commented 1 year ago

optimises dockerfile build steps, improves the github actions workflow, and solves the core plugins issue

luludotdev commented 1 year ago

I'm under the assumption that the failing GH Actions are caused by reasons outside of this PR. If this is the case, then this PR looks good to me.

the docker workflowhad an issue with submodules, since been fixed

the .net workflow seems to have an issue with whoever wrote it failing to account for it running on external pull requests, as it is trying to log in as me to publish packages, which is obviously failing because I do not have the required permissions

Caeden117 commented 1 year ago

We can ignore that step when building PRs. I can make a separate PR for that soon. I'm not sure if we want every single incoming PR to be published to NuGet?