Closed sc2ad closed 3 years ago
You do need to fix those build errors though
Only things left should be documentation. Feel free to take a look at my commit re: conversions from JsonElement to actual instances (GetRawString
should almost always be far, far, faster than WriteTo
combined with JsonSerializer.Deserialize<T>(ref reader)
because the raw string has already been allocated)
Just realized I forgot to actually make this PR, figured I should.
This PR refactors
HiveObjectQuery
and adjusts many of the model types to better support additional data modification (TODO: We may still want some form of conversion instead of havingobject
everywhere?)This also fixes the forever-present issue of
Forbid
not working due to not having an authentication scheme set, as well as adding new plugin functionality for users as well as adjusting some other plugins to make making tags/other forms of additional data modification possible.Oh, and I'll also merge master into here shortly to make the merge conflicts go away