AtlasMediaGroup / IcarusMod

The Superior Freedom Network custom plugin.
Other
8 stars 13 forks source link

Override SQL Requirement Command #108

Open Hockeyfan360 opened 9 years ago

Hockeyfan360 commented 9 years ago

You are probably asking why this would be useful. For people that do not own and do not want to purchase/set up an SQL server, this might be useful. It would disable the check when the plugin enables, for SQL. This would make it easier to test development on a local computer (if you don't own an SQL server)

In other words, you can prevent IcarusMod from disabling itself and saying this:

"[IcarusMod] Hostname is null in the config....

Wild1145 commented 9 years ago

The entire plugin is designed to be multi-server and depends on a database. Removing the DB checks would be of huge problems. Not to mention you can get a Free MySQL Database if you really wanted too anyway.

Hockeyfan360 commented 9 years ago

This isn't for the actual server, it would be for testing purposes. (Such as testing new commands/modules that do not require sql.)

Wild1145 commented 9 years ago

It should run anyway, the plugin wont disable. Its just that nearly everything depends on the MySQL intentionally.

Hockeyfan360 commented 9 years ago

Username is null in the config, please stop the server, ammend the fault and then restart. IcarusMod will not load until this error is resolved.

After that, it does disable it.

Wild1145 commented 9 years ago

Hmmm, it never used to disable it. Perhaps we add a Debug / similar mode that when enabled just runs as usual then?

Hockeyfan360 commented 9 years ago

Should we just add a boolean for developers in the code, that acts as the debug switch?

(Also, incase you were un-aware, bukkit does not disable it automatically. The plugin has a line written to disable itself, which I find very useless.)

Wild1145 commented 9 years ago

I was just going to chuck something in the config.yml so if its true it will just skip past that part of the load code.

CameronRedmore commented 9 years ago

ah, I threw those automatic disablers in there so that people running it for the first time wouldn't think the plugin is just botched. If you just throw any random details in the config it should still load but I don't think many features will work correctly.

Wild1145 commented 8 years ago

I think this is something we should look at, but as a low priority. Ultimately this is designed as a multi-server plugin, and MySQL servers are easy enough to get, even free ones are out there.

Hockeyfan360 commented 8 years ago

@Wild1145 Maybe instead of this we could link people to the mysql server installation files for a local testing server. I agree with the earlier you, there would be no purpose.