search

AtlasMediaGroup / IcarusMod

The Superior Freedom Network custom plugin.
Other
8 stars 12 forks source link

Fixes and updates #139

Closed mgejay closed 9 years ago

mgejay commented 9 years ago

closes #138 and fixes some things

mgejay commented 9 years ago

@Wild1145 @Hockeyfan360

Hockeyfan360 commented 9 years ago

@Scuph Please make the appropriate changes. I am going to push to the repo with the fix regarding class names.

mgejay commented 9 years ago

@Hockeyfan360 changes made

mgejay commented 9 years ago

@Hockeyfan360 This was tested, no errors, will it be merged?

Wild1145 commented 9 years ago

Closed for inactivity.

mgejay commented 9 years ago

@Wild1145 The hell? I finished my updates with this thing and no one has told me to make any changes. Reopen this please.

Wild1145 commented 9 years ago

@ScuphGamingUK It still had problems according to the tags. However I will reopen and recheck

Wild1145 commented 9 years ago

@ScuphGamingUK Right now the commit will not merge. This will need to be fixed but as this is a 1.2 PR I will leave it open until we finish the 1.1 release.

Wild1145 commented 9 years ago

@ScuphGamingUK Okay... Apparently the milestone was mis-labeled. If you can fix the issue where it won't merge hopefully we will be good.

mgejay commented 9 years ago

@Wild1145 What are the new params?

Wild1145 commented 9 years ago

@scuphgaminguk The params for the optional reason as I dont belice they are part of it right now. This also still cannot be merged to the main branch so will need to be fixed before I can pull it in.

mgejay commented 9 years ago

@Wild1145 what is causing it to be unmergable?

Wild1145 commented 9 years ago

Im not sure, by the looks of it its not in sync with the current main branch.

Hockeyfan360 commented 9 years ago

As we have already implemented these features, this PR is closed.