AtlasMediaGroup / IcarusMod

The Superior Freedom Network custom plugin.
Other
8 stars 13 forks source link

Add blacklist and list of blacklisted phrases/characters #180

Closed mgejay closed 7 years ago

mgejay commented 8 years ago

Solves #177

CameronRedmore commented 8 years ago

This seems to be okay, there is no nick blacklist however.

Wild1145 commented 8 years ago

The blacklist should be stored as part of the settings table in mySQL

mgejay commented 8 years ago

@Wild1145 That would create more data for no reason. The blacklist doesn't disappear on a reload or restart like HashMaps and ArrayLists, this is always there and works just fine, no need to create more work and fix something if it isn't broken.

Wild1145 commented 8 years ago

@Adaptified It does however need to be centrally stored and able to be updated in real time as we need.

mgejay commented 8 years ago

@Wild1145 You're developers, it's not hard to edit the code. That's why github is here, people suggest something and then it happens. Not everything needs to be SQL.

Wild1145 commented 8 years ago

@Adaptified The entire point of this project is that it is fully SQL based, no configigs and everything is global. I and @CameronRedmore may be Java developers, but @TheCJGCJG is not, neither is Varuct, so if they want to make a change, they have to wait for me or Camzie to be free, make the change, test the change and then push and compile. We then have to take the network offline to update it. Or we just follow the project goals to SQL everything and make one minor change to a table and boom, done.

mgejay commented 8 years ago

@Wild1145 Done.

CameronRedmore commented 8 years ago

The blacklist this takes is simply a comma delimited list in the format: "Admin, Mod, Super, Senior, Telnet, Developer, Manager, Executive, &k, &o, &n, &m, &1, &0" for example. If this string is entered as the value for a new row in the 'settings' table which is named 'blacklist' all of those terms would be blacklisted.

mgejay commented 8 years ago

Holy formatting issues. I am guessing you want the bracket under the statement.

Wild1145 commented 8 years ago

@Adaptified It should be in allman style. Just like TFM.

mgejay commented 8 years ago

@Wild1145 All done.