AtlasOfLivingAustralia / ala-bie-hub

BIE (Biodiversity Information Explorer) hub - merge of old ala-bie and bie-plugin
Mozilla Public License 2.0
1 stars 5 forks source link

Ensure preferred common name is identical on search results and species page #3

Open charvolant opened 2 years ago

charvolant commented 2 years ago

For example https://bie.ala.org.au/search?sortField=score&dir=desc&q=Bellis+perennis gives 'English Daisy' but https://bie.ala.org.au/species/https://id.biodiversity.org.au/node/apni/2888214#overview gives 'Daisy'.

adam-collins commented 11 months ago

This fix is included with the new names index that is in development.

adam-collins commented 5 months ago

There is a change in expectations. The common name that the BIE and namematching return will not be the same, just less random.

adam-collins commented 2 months ago

I think there needs to be a change to the species page as well as it is using a different method to source the common name and can display multiple common names.

commonNameSingle, at least, should appear on the species page to be more consistent. https://bie-test.ala.org.au/search?q=https://id.biodiversity.org.au/taxon/apni/51437865

adam-collins commented 2 months ago

This is up on test. Now using commonNameSingle consistently on the search result and show page. This issue is now waiting on bie-index vernacular name sync with namematching-ws.

adam-collins commented 2 months ago

See the linked issue for testing details.

kylie-m commented 2 months ago

Tested as per linked issue, passed. As expected, is also functioning well in UI - ie, names match between search results and species page