search

AtlasOfLivingAustralia / ala-keys-ui

(Prototype) UI like keybase using ala-keys services
0 stars 0 forks source link

Keys list jumps back to Projects list after delete key #12

Closed KevinThiele closed 8 years ago

KevinThiele commented 8 years ago

Go to a project's listing of keys. Delete a key. Instead of remaining on the keys list page, KeyBase jumps back to the Projects page.

nielsklazenga commented 8 years ago

Fixed. Only tried it out in DEV though, so let me know if it doesn't work in PRODUCTION.

KevinThiele commented 8 years ago

Better, but after deleting a key (from key list view) it now jumps back to key tree view - better to return to list view (may want to delete several keys) - best to return to the same place in the page

nielsklazenga commented 8 years ago

That is not standard behaviour when you go back to a page. KeyBase doesn't know if the key was deleted from the tree or from the list.

KevinThiele commented 8 years ago

But you can only delete from the list.

k

From: Niels Klazenga [mailto:notifications@github.com] Sent: Wednesday, 2 March 2016 8:02 AM To: AtlasOfLivingAustralia/ala-keys-ui ala-keys-ui@noreply.github.com Cc: KevinThiele kevin.thiele@eubio.consulting Subject: Re: [ala-keys-ui] Keys list jumps back to Projects list after delete key (#12)

That is not standard behaviour when you go back to a page. KeyBase doesn't know if the key was deleted from the tree or from the list.

— Reply to this email directly or view it on GitHub https://github.com/AtlasOfLivingAustralia/ala-keys-ui/issues/12#issuecomment-190978197 . https://github.com/notifications/beacon/AQRA5KaWgpY21Hx4MZILfYGsdxXMSVorks5ppNOVgaJpZM4Hkx1K.gif

nielsklazenga commented 8 years ago

You can delete from the tree as well: image

The point is, by the way, that the tree and the list are on the same page, in contrast to the previous version, where they were different pages.

KevinThiele commented 8 years ago

Good – I see now. Problem was simply that I hadn’t caught up that there was a right-click menu now.

nielsklazenga commented 8 years ago

Has been there all along.

KevinThiele commented 8 years ago

How could I have missed it?

From: Niels Klazenga [mailto:notifications@github.com] Sent: Wednesday, 2 March 2016 3:40 PM To: AtlasOfLivingAustralia/ala-keys-ui ala-keys-ui@noreply.github.com Cc: KevinThiele kevin.thiele@eubio.consulting Subject: Re: [ala-keys-ui] Keys list jumps back to Projects list after delete key (#12)

Has been there all along.

— Reply to this email directly or view it on GitHub https://github.com/AtlasOfLivingAustralia/ala-keys-ui/issues/12#issuecomment-191113178 . https://github.com/notifications/beacon/AQRA5D8kdZ88bqsYsAcjCkCL18S6gbJCks5ppT7PgaJpZM4Hkx1K.gif