AtlasOfLivingAustralia / avh-hub

Australian Virtual Herbarium
https://avh.ala.org.au
Mozilla Public License 2.0
4 stars 2 forks source link

Identification properties in BioCache record #116

Closed nielsklazenga closed 7 months ago

nielsklazenga commented 3 years ago

Hi Nick, Another issue for which I do not know in which repository it should go. The occurrence details pages for the MEL AVH records look really good now, now that I deliver everything that I can.

Having a good look at the pages (https://avh.ala.org.au/occurrences/28ba3914-d21f-4608-bec2-48bddb1eb85f for example) though shows some minor issues:

Looking at the record from the web service (https://biocache-ws.ala.org.au/ws/occurrences/28ba3914-d21f-4608-bec2-48bddb1eb85f), it shows that dateIdentified, as expected, is in there once, so that is probably something in the BioCache Hubs/AVH Hub code, and also that identificationVerificationStatus is already there as 'verified', so that is probably done in the BioCache Store (?). I also note that identifiedBy does not come through in the processed data, but shows on the page correctly.

Provided (raw)

{
    "identification": {
      "dateIdentified": "2018-07",
      "identificationID": "db7d67a1-bd84-4e99-ba61-6695fe82316c",
      "identifiedBy": "Guo, S.L.; Li, D.D."
    }
}

Processed

{
    "identification": {
      "dateIdentified": "2018-07",
      "identificationQualifier": "Not provided",
      "identificationVerificationStatus": "verified",
      "abcdIdentificationQualifier": "Not provided"
    },
}

There is probably some rationale behind the identificationVerificationStatus that I am not aware of, so the only thing that really needs to be fixed is removing the duplicate dateIdentified (I suggest removing 'identified date'). I hope that is an easy fix.

adam-collins commented 7 months ago

dateIdentified is addressed by https://github.com/AtlasOfLivingAustralia/biocache-hubs/issues/546

identificationVerificationStatus appears to be absent in the given example. I take that to mean it is fixed.