Open kylie-m opened 1 year ago
These will be fixed in the new names index with the addition of a field in the name-matching-service's index.
will be fixed in the new backbone - suspect this is a duplicate of other issues
A duplicate issue of https://github.com/AtlasOfLivingAustralia/ala-bie-hub/issues/3
related but not a duplicate?
I assume that most recent comment is asking if it this issue is related to the linked issue only by the keyword common name
.
This is not the case. Both are identical because the current vernacularname.txt
does not indicate the preferred common name.
The new index fixes this issue because vernacularname.txt
has the field <field index="13" term="http://rs.gbif.org/terms/1.0/isPreferredName"/>
, see the work in progress index https://archives.ala.org.au/archives/nameindexes/20230725-3/
.
Of course this does depend on the work being finished:
isPreferredName
, but it is not populated correctly yet.Princess Parrot
is the preferred common name, which would fix this issue. The work in progress index does not contain Alexandra's Parrot
and while this would also fix the problem described, because there are no other common names for this LSID, it is clear that this is still incomplete work because the non-preferred common name was removed while still being a common name in use https://lists.ala.org.au/speciesListItem/list/dr656?q=Polytelis+alexandrae, http://www.environment.gov.au/cgi-bin/sprat/public/publicspecies.pl?taxon_id=758. There is a change in expectations. The common name that the BIE and namematching return will not be the same, just less random.
Now aligned with namematching service. For example bie-index returns commonNameSingle
that is the same as namematching vernacularName
, search result, species page, bie-index, namematching
Please test, on test
commonNameSingle
in bie-index is the same as the vernacularName
in namematching.commonNameSingle
is the prominent common name, where there are more than one, in ala-bie-hub.Looks like it's all working ok, passing for me. @CamSlatyer and @TaniaGLaity do you have anything else to add here?
Items tested:
commonNameSingle
in bie-index is the same as the vernacularName
in namematching:
tested & passed for Princess Parrot:
-- vernacularName
in name matching = Princess Parrot https://api.test.ala.org.au/namematching/api/getByTaxonID?taxonID=https%3A%2F%2Fbiodiversity.org.au%2Fafd%2Ftaxa%2Fbe7a08f5-387f-4156-91e2-77f0d3d09d8c&follow=false
-- commonNameSingle
in bie-index matches, ie = Princess Parrot https://bie-ws-test.ala.org.au/ws/species/https://biodiversity.org.au/afd/taxa/be7a08f5-387f-4156-91e2-77f0d3d09d8c
-- & same as above for English daisy - https://bie-ws-test.ala.org.au/ws/species/https://id.biodiversity.org.au/node/apni/2888214 & https://api.test.ala.org.au/namematching/api/getByTaxonID?taxonID=https://id.biodiversity.org.au/node/apni/2888214
commonNameSingle
is the prominent common name, where there are more than one, in ala-bie-hub:
tested - passed - correct commonNameSingle
for 'English daisy' https://bie-ws-test.ala.org.au/ws/species/https://id.biodiversity.org.au/node/apni/2888214
Looks good to me.
I think it looks good to me too..
Me too
From: TaniaGLaity @.> Sent: Tuesday, May 7, 2024 2:47 PM To: AtlasOfLivingAustralia/bie-index @.> Cc: Slatyer, Cam (NCMI, Black Mountain) @.>; Mention @.> Subject: Re: [AtlasOfLivingAustralia/bie-index] Common names on species pages are not showing preferred name (Issue #373)
I think it looks good to me too..
— Reply to this email directly, view it on GitHubhttps://github.com/AtlasOfLivingAustralia/bie-index/issues/373#issuecomment-2097437789, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5GVKFPY5MRCMHSP3U46LKLZBBME7AVCNFSM6AAAAAA3JRKISGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJXGQZTONZYHE. You are receiving this because you were mentioned.Message ID: @.***>
Common names on species pages are not showing preferred names.
For example, the Princess Parrot is now Alexandra's Parrot. https://bie.ala.org.au/species/https://biodiversity.org.au/afd/taxa/be7a08f5-387f-4156-91e2-77f0d3d09d8c
This isn't the preferred name for the species in AFD or the BirdLife list.