search

AtlasOfLivingAustralia / bie-index

Taxonomic search services
https://bie-ws.ala.org.au/ws
Other
1 stars 17 forks source link

Common names on species pages are not showing preferred name #373

Open kylie-m opened 1 year ago

kylie-m commented 1 year ago

Common names on species pages are not showing preferred names.

For example, the Princess Parrot is now Alexandra's Parrot. https://bie.ala.org.au/species/https://biodiversity.org.au/afd/taxa/be7a08f5-387f-4156-91e2-77f0d3d09d8c

This isn't the preferred name for the species in AFD or the BirdLife list.

adam-collins commented 1 year ago

These will be fixed in the new names index with the addition of a field in the name-matching-service's index.

TaniaGLaity commented 8 months ago

will be fixed in the new backbone - suspect this is a duplicate of other issues

adam-collins commented 7 months ago

A duplicate issue of https://github.com/AtlasOfLivingAustralia/ala-bie-hub/issues/3

TaniaGLaity commented 7 months ago

related but not a duplicate?

adam-collins commented 7 months ago

I assume that most recent comment is asking if it this issue is related to the linked issue only by the keyword common name.

This is not the case. Both are identical because the current vernacularname.txt does not indicate the preferred common name.

The new index fixes this issue because vernacularname.txt has the field <field index="13" term="http://rs.gbif.org/terms/1.0/isPreferredName"/>, see the work in progress index https://archives.ala.org.au/archives/nameindexes/20230725-3/.

Of course this does depend on the work being finished:

  1. The work in progress index has the field isPreferredName, but it is not populated correctly yet.
  2. The current index does not indicate Princess Parrot is the preferred common name, which would fix this issue. The work in progress index does not contain Alexandra's Parrot and while this would also fix the problem described, because there are no other common names for this LSID, it is clear that this is still incomplete work because the non-preferred common name was removed while still being a common name in use https://lists.ala.org.au/speciesListItem/list/dr656?q=Polytelis+alexandrae, http://www.environment.gov.au/cgi-bin/sprat/public/publicspecies.pl?taxon_id=758.
adam-collins commented 7 months ago

There is a change in expectations. The common name that the BIE and namematching return will not be the same, just less random.

adam-collins commented 3 months ago

Now aligned with namematching service. For example bie-index returns commonNameSingle that is the same as namematching vernacularName, search result, species page, bie-index, namematching

Please test, on test

kylie-m commented 3 months ago

Looks like it's all working ok, passing for me. @CamSlatyer and @TaniaGLaity do you have anything else to add here?

Items tested:

Sherrin-ALA commented 3 months ago

Looks good to me.

TaniaGLaity commented 3 months ago

I think it looks good to me too..

CamSlatyer commented 3 months ago

Me too

From: TaniaGLaity @.> Sent: Tuesday, May 7, 2024 2:47 PM To: AtlasOfLivingAustralia/bie-index @.> Cc: Slatyer, Cam (NCMI, Black Mountain) @.>; Mention @.> Subject: Re: [AtlasOfLivingAustralia/bie-index] Common names on species pages are not showing preferred name (Issue #373)

I think it looks good to me too..

— Reply to this email directly, view it on GitHubhttps://github.com/AtlasOfLivingAustralia/bie-index/issues/373#issuecomment-2097437789, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5GVKFPY5MRCMHSP3U46LKLZBBME7AVCNFSM6AAAAAA3JRKISGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJXGQZTONZYHE. You are receiving this because you were mentioned.Message ID: @.***>