Open kylie-m opened 1 month ago
Raised via user support
Current workaround is to follow the link to Biocache:
JS errors in console - looks like its trying to reference the content of a dom element that no longer exists on page:
TypeError: Cannot read properties of undefined (reading 'split') at HTMLTableRowElement.
(exploreYourArea.unminified.js:3093:26)
$('#rightList tbody tr').bind('click.specieslink', function(e) {
e.preventDefault(); // ignore the href text - used for data
var thisTaxonA = $(this).find('a.taxonBrowse2').attr('href').split('/');
EDIT: that is triggered when you click the link at the bottom of the list Show more species
- does not account for the automatic loading of the list, which should happen when the user scrolls to the end of the list. There are no errors in this scenario, which suggests the event is not being triggered.
Latest code works fine on local dev setup and I noticed that prod is using an old version of biocache-hubs
, suggesting this is the cause.
NVM, didn't read details above properly and missed the bit about (other than "All species").
Found the bug and fixed the group names with square braces around them as well.
Hi @nickdos FYI it's also just been flagged by a second user that sorting by name/number is failing.
I've replicated this on ALA, AVH and Ozcam by:
[no species found]
Thanks @kylie-m, I did pick that up and fixed it as well. The code for both was in the same block and used the essentially the same logic. Both are fixed and I'll deploy to test later today.
@kylie-m - would you mind testing my fix that is deployed to test, please?
@nickdos working well for me on ALA EYA, I tested the fixed issues plus general test cases on # 6 of Biocache hubs testing docs. All passing - thanks again for this!
Just noting AVH and Ozcam EYA's are still failing on test but I assumed the fix wasn't deployed there
Just noting AVH and Ozcam EYA's are still failing on test but I assumed the fix wasn't deployed there
@kylie-m - yes, I did not deploy those hubs yet. I just wanted to check this issue and those 2 hubs are not officially supported for "explore your area" - that page exists but is not linked to/from anywhere on those site. So its a ghost page for them.
@qifeng-bai has code reviewed this change
Explore Your Area is now only showing the top 50 species per group, except for "All species". This is happening on ALA, AVH and Ozcam explore your area tools.
Steps to replicate:
Go to explore your area, search any location
Click on any group (other than "All species") with more than 50 species
Scroll down the list of species, verify that only 50 are showing
At the bottom of the list, click on 'Show more species'. It now displays "[no species found]":
Other testing notes: I've tested using Chrome, Firefox, Safari and Edge, getting the same results