AtlasOfLivingAustralia / biocache-service

Occurrence & mapping webservices
https://biocache-ws.ala.org.au/ws/
Other
9 stars 26 forks source link

Batch taxon name search error #734

Closed Rita-C closed 5 months ago

Rita-C commented 2 years ago

Application error occurred when testing https://github.com/AtlasOfLivingAustralia/biocache-hubs/issues/245:

Steps to produce:

  1. On the search page, the "batch taxon search" tab. (https://biocache-test.ala.org.au/search#tab_taxaUpload)
  2. Search for Phyllanthus hirtellus F.Muell. ex Müll.Arg. in both raw and non-raw form. Raw form should return about 70 records, non-raw the lot
    • Supplied name -> 73 records
    • matched name ->
      Application error
      Failed to get json from web service (https://biocache-ws-test.ala.org.au/ws/occurrences/search?q=qid%3A1642727109168&qualityProfile=ALA&start=0&pageSize=20&sort=first_loaded_date&dir=desc&qc=&facets=taxon_name%2Cfamily%2Cspecies_group%2Ccommon_name%2Cmonth%2Coccurrence_decade_i%2Cstate%2Cbasis_of_record%2Cmultimedia%2Coccurrence_status%2CcontentTypes%2Cassertion_user_id%2Cinstitution_uid%2Cdata_resource_uid&flimit=10). class org.grails.web.converters.exceptions.ConverterException Error parsing JSON, org.grails.web.converters.exceptions.ConverterException: Error parsing JSON; nested exception is org.grails.web.converters.exceptions.ConverterException: Error parsing JSON
nickdos commented 2 years ago

https://biocache-ws-test.ala.org.au/ws/occurrences/search?q=taxa:%22Phyllanthus%20hirtellus%20F.Muell.%20ex%20M%C3%BCll.Arg.%22 replicates the issue without going via the UI.

I note prod has the same problem but going via biocache-hubs does not: https://biocache.ala.org.au/occurrences/search?taxa=Phyllanthus+hirtellus+F.Muell.+ex+M%C3%BCll.Arg. So I'm guessing hubs is performing some URL encoding before sending it to biocache-service.

adam-collins commented 9 months ago

pull request https://github.com/AtlasOfLivingAustralia/biocache-service/pull/864

peggynewman commented 5 months ago

https://biocache-ws-test.ala.org.au/ws/occurrences/search?q=taxa:%22Phyllanthus%20hirtellus%20F.Muell.%20ex%20M%C3%BCll.Arg.%22 returns records now