AtlasOfLivingAustralia / biocache-store

Occurrence processing, indexing and batch processing
Other
7 stars 24 forks source link

PointsReader log message is indecipherable #253

Closed ansell closed 6 years ago

ansell commented 6 years ago

The log message created by PointsReader when a point fails to parse is indecipherable due to the way the string concatenation is occurring right now:

2018-05-22 13:02:53,752 INFO : [PointsReader] - Loading points from file: /data/tmp/loc-dr342.txt
2018-05-22 13:02:53,867 ERROR: [PointsReader] - Error reading point: [Ljava.lang.String;@7c3ebc6b
2018-05-22 13:05:08,090 INFO : [Sampling] - Total points sampled so far : 52821

The message on 2.x will be better due to the inclusion of the Exception that triggered the failure, but it still may not contain the original point due to the String being concatenated in the same way:

https://github.com/AtlasOfLivingAustralia/biocache-store/blob/2.x/src/main/scala/au/org/ala/biocache/tool/Sampling.scala#L262

djtfmartin commented 6 years ago

this is now fixed