New image-service demands apikey for image uploading

AtlasOfLivingAustralia / biocache-store

Occurrence processing, indexing and batch processing

Other

7 stars 24 forks source link

New image-service demands apikey for image uploading #337

Closed andrevtg closed 4 years ago

andrevtg commented 5 years ago

It seems to me that image-service (1.0.x) requires api keys in special http headers for certain endpoints (including image uploads at "/ws/uploadImage") and biocache does not provide it. I had no issues with that on 0.9.x, but I'm not sure if this is just a setting I missed.

I'll try to submit a PR for that.

ansell commented 5 years ago

I think that is part of this PR that I am currently reviewing: https://github.com/AtlasOfLivingAustralia/biocache-store/pull/336

andrevtg commented 5 years ago

Nice. I'll use my custom biocache until next release. Thanks for pointing this out.

ansell commented 4 years ago

@andrevtg The pull request was merged and a new version of biocache-store has been released. Can you test it to verify it is working for you against your image-service (may need to bump to the image-service version that was also released in the last few hours)

djtfmartin commented 4 years ago

@andrevtg note the API checks can be bypassed by whitelisting IP address

security:
  apikey:
    ip:
      whitelist: 123.123.123.123,124.124.124.124

andrevtg commented 4 years ago

Thanks, Dave, I am aware of that. The problem is we are deploying ALA as containers on Kubernetes, so no fixed IPs should be used.