AtlasOfLivingAustralia / collectory

Metadata registry for the Atlas
https://collections.ala.org.au
Other
0 stars 15 forks source link

Collections: problem creating ProviderMaps then causing 500 errors in collectory #214

Closed rosemaryjoconnor closed 11 months ago

rosemaryjoconnor commented 1 year ago

Production: Error 500 occurring when trying to create Provider map for the following provider codes:

This is similar to the issue encounter in collections-test: https://github.com/AtlasOfLivingAustralia/collectory/issues/206

Checking the provider maps I can't see any duplication, though it looks like it's happened at some point.

any help is appreciated

Image

adam-collins commented 1 year ago

I can replicate the issue if I select from the codes lists instead of using the drop downs. Is this the process you were using?

Anyhow, the provider map already exists in test, https://collections-test.ala.org.au/providerMap/show/167?returnTo=

adam-collins commented 1 year ago

I will take a look at removing the error and make sure duplication error message is shown when appropriate.

peggynewman commented 1 year ago

Cheers Adam, from memory I think it's also difficult to search for existing providerMaps...?

adam-collins commented 1 year ago

Settled on these changes:

Provider maps are unique by the collection drop down. It does not show duplicates so it is not possible to create a duplicate.

These changes are in the commit https://github.com/AtlasOfLivingAustralia/collectory/commit/aa3719e22daefcaeefd210d728595291dfb7ceb8

rosemaryjoconnor commented 1 year ago

Hi adam thanks. Yes, I was using the codes lists for both collection and institution, this seemed to be the only way I could get things to work correctly in test.

Is there a possibility of a search function for Provider Maps or at least be able to sort by the Institution or collection code?

adam-collins commented 1 year ago

This is on collections test for testing

rosemaryjoconnor commented 1 year ago

Hi Adam, ok I now realise why I was using the code lists. If for example you choose Institution: Tasmanian Museum and Art Gallery, no collection codes display in the dropdown to select.

In order to create the Provider map I had to select from the code lists, that is:

There are a few other things re the UI that are quite confusing:

For both of the above I can understand how that may be resolved in the back-end when matching but it does make the UI confusing.

If we are using this incorrectly any help is appreciated but I couldn't find any other way to make it work.

thoughts?

adam-collins commented 1 year ago

A slight change in procedure may be required:

  1. On the page listing provider maps (https://collections-test.ala.org.au/providerMap/list), click 'list all providerMaps'. This will reload the page with all provider maps listed on a single page so that you can do a text search for the collection name.
  2. Search for the collection name (not collection code). Provider Maps are unique by the collection name. If a provider map already exists for a collection you will not be able to reselect that same collection, preventing a duplicate from being created.
  3. If you find the collection name, edit that provider map
  4. If you don't find the collection name, create a new provider map.
  5. (Optional) Selecting the institution will also apply a filter to the list of collection names. If you don't find the collection it may already have an existing provider map or may not be linked to the institution.
  6. Select the collection name from the drop down list.
  7. (Optional) select one or more institution and collection codes from the list boxes.
  8. Save.

Further notes: