AtlasOfLivingAustralia / collectory

Metadata registry for the Atlas
https://collections.ala.org.au
Other
0 stars 15 forks source link

error cause by deleting an institution #232

Closed adam-collins closed 6 months ago

adam-collins commented 9 months ago

Deleting an institution should also remove that institution from child_institutions field elsewhere. If not then viewing the parent institution will fail because of a null produced by Institution:listChildren.

Do a quick check through other domains for similar instances of unenforced dependencies.

adam-collins commented 6 months ago

After a discussion, while this feature may be desirable (ability to set child_institutions), it is not currently functional. There is nothing in the UI to edit or view this field today.

To resolve this issue I will be setting child_institution values to null in prod and test.

Here is a record of what is being removed from test.

mysql> select uid, child_institutions from institution where child_institutions is not null;
+------+--------------------+
| uid  | child_institutions |
+------+--------------------+
| in5  | in67               |
| in6  | in5                |
| in36 | in5 in75           |
| in40 | in67               |
| in42 | in67               |
| in44 | in17               |
+------+--------------------+

Here is a record of what is being removed from prod.

mysql> select uid, child_institutions from institution where child_institutions is not null;
+------+--------------------+
| uid  | child_institutions |
+------+--------------------+
| in5  | in67               |
| in6  | in5                |
| in12 |                    |
| in36 | in5 in75           |
| in40 | in67               |
| in42 | in67               |
| in44 | in17               |
+------+--------------------+