search

AtlasOfLivingAustralia / doi-service

ALA DOI minting service - integrates with ANDS to produce the DOI, provides a landing page, and stores the associated file
https://doi.ala.org.au/
0 stars 4 forks source link

Added DataCite support #55

Closed vjrj closed 4 years ago

vjrj commented 4 years ago

I added DataCite support using the gbif-doi library (thanks to @timrobertson100 for the suggestion and for help providing me some test datacite account).

I tested minting test DOIs using api.test.datacite.org but in short I'll try with the production API in: https://doi.gbif.es

I'll also send an additional PR to ala-install to allow the configuration of the new variables.

vjrj commented 4 years ago

Off course, thanks for the review.

Sorry, I'm a java guy using a java library here, so many times I missed groovy. I added and deleted a lot of semicolons :-P

vjrj commented 4 years ago

Hi @sbearcsiro I followed all your comments. All tests, etc worked. But in some point for some reason, the pages are unstyled, without header/footer. This also happened to me testing some recents versions and snapshots from nexus via ala-install. Can you share your configuration skin and headerAndFooter configuration?

2020-09-05-09:06:48-screenshot

brucehyslop commented 4 years ago

A new issue #57 has been created to address the broken style.

brucehyslop commented 4 years ago

broken style has been fixed.

@sbearcsiro are you happy with the requested changes?

nickdos commented 4 years ago

Bump @sbearcsiro