search

AtlasOfLivingAustralia / doi-service

ALA DOI minting service - integrates with ANDS to produce the DOI, provides a landing page, and stores the associated file
https://doi.ala.org.au/
0 stars 4 forks source link

Styling broken in test site #57

Closed nickdos closed 4 years ago

nickdos commented 4 years ago

Header and footer are not showing up on test site.

May be related to ala-boostrap3-plugin version.

brucehyslop commented 4 years ago

The issue appears to be with the ansible configuration there was a change made (https://github.com/AtlasOfLivingAustralia/ala-install/commit/3434b26df72b73b9a39fa01b452647d906e456a2) that sets the default to main this should probably be ala-main

nickdos commented 4 years ago

Thanks @brucehyslop. The plugin should provide a mapping from main to ala-main for backwards compatibility so not sure why it no longer works. Could you check that the client app hasn't included its own main layout, which might be taking precedence to the plugin version.

brucehyslop commented 4 years ago

the application.yml defaults the skin.layout to ala-main however the ansible doi-service-config.yml template is 

skin:
  layout: {{ skin_layout | default('main') }}

my suspicion is that there is no skin_layout variable set so it's defaulting to main.

I'm not familiar with ansible so not 100% sure. The change to the ansible was reasonably recent (2020-04-28) and the only change I can see that would cause this behaviour. Prior to this change ala-main would have been used from application.yml.

brucehyslop commented 4 years ago

I've change ansible doi-test inventory to set the site_layout=ala-main rerun ansible-playbook for doc-test.

The style is now working on https://doi-test.ala.org.au/

@vjrj the default skin.layout does not match the layout defined in application.yml

vjrj commented 4 years ago

Thanks indeed @brucehyslop . It works for me also using development branch with ala-main.