search

AtlasOfLivingAustralia / doi-service

ALA DOI minting service - integrates with ANDS to produce the DOI, provides a landing page, and stores the associated file
https://doi.ala.org.au/
0 stars 4 forks source link

ALA banner appears twice #58

Closed nickdos closed 4 years ago

nickdos commented 4 years ago

The banner message that is configured via the alaAdmin page is currently showing the banner message twice.

image

The banner appears to be hard-coded, as it is not using the value from the /alaAdmin page, which is the blue box below.

image

brucehyslop commented 4 years ago

The issue is that the taglib <ala:systemMessage/> is included in the views and also in the ala-main layout.

We can remove it from the views that use a layout that also displays the system message, however since the layout is configurable it would be possible to use a layout that does not display the system message.

nickdos commented 4 years ago

Meant to leave this comment here. Still seeing 2 banners on test site.

Rita-C commented 4 years ago

Hi @brucehyslop, the double banner is still showing in Test, @nickdos and I tested this morning, can you take another look please?

ansell commented 4 years ago

I removed the "This is a test site" banner on doi-test:

https://github.com/AtlasOfLivingAustralia/ansible-inventories/blob/master/doi/doi-test#L12-L14

It was causing confusion about the two different banners that ala-admin-plugin adds:

https://github.com/AtlasOfLivingAustralia/ala-admin-plugin/blob/a87d87a3720c14f6f04fb9c5215cd9f4be571cd5/grails-app/taglib/au/org/ala/admin/SystemMessageTagLib.groovy#L8-L35

I also switched the default on ala-install so that it will default to production if it isn't otherwise configured, which matches our other "production by default" settings in ala-install:

https://github.com/AtlasOfLivingAustralia/ala-install/commit/62fab34d2b161f25302f19c4e764e659b17a9876

The original issue here with the grails templates where the ala-admin-plugin systemMessage was put in twice has been fixed.