search

AtlasOfLivingAustralia / doi-service

ALA DOI minting service - integrates with ANDS to produce the DOI, provides a landing page, and stores the associated file
https://doi.ala.org.au/
0 stars 4 forks source link

issue #58 ALA banner appears twice #59

Closed brucehyslop closed 4 years ago

brucehyslop commented 4 years ago

Removed the <ala:systemMessage/> taglib from views (the system message in included in the ala-main layout) added default layout to the notfound and unauthorised views

Note: any LA deployments use a layout that doesn't include the <ala:systemMessage/> will no longer display the system banner.

nickdos commented 4 years ago

Hi @sbearcsiro I was testing this and I'm still seeing 2 banners on the test site, which appears to be running the latest version (fc753cf) from the develop branch. Any ideas?

brucehyslop commented 4 years ago

@nickdos, I suspect the issue is that there are multiple system messages defined in the /data/doi-service/config/system-message.json.

nickdos commented 4 years ago

The banners have different styling and different message text. The alaAdmin plugin should be the only code writing to the system-message.json file, so it should also be clearing it when removing the message (via alaAdmin UI), which is not happening at the moment - "This is a TEST site" persists. Checking the json file I can see its empty after clearing the alaAdmin version:

{
    "message": {

    }
}