DOI page should have human readable explanations for the filters.

AtlasOfLivingAustralia / doi-service

ALA DOI minting service - integrates with ANDS to produce the DOI, provides a landing page, and stores the associated file

https://doi.ala.org.au/

0 stars 4 forks source link

DOI page should have human readable explanations for the filters. #87

Closed sughics closed 9 months ago

sughics commented 1 year ago

Raised by @peggynewman

DOI page should have human readable explanations for the filters. The text at the top replicates the text in the table. Bad look.

adam-collins commented 1 year ago

Removed duplicates https://github.com/AtlasOfLivingAustralia/doi-service/pull/88

adam-collins commented 1 year ago

Some feedback on the human readable data quality filters please

sughics commented 1 year ago

Some feedback on the human readable data quality filters please

@peggynewman

peggynewman commented 1 year ago

Hi @adam-collins, @sughics I think we should represent both the query filter code and the human explanation. The issue was that just the query filter code was represented twice. I don't think we should remove it all together.

adam-collins commented 1 year ago

filter code returned in the pull request.

peggynewman commented 1 year ago

The DQ filters have a nicer description field: https://data-quality-service.ala.org.au/filters/92

eg Exclude records with location related data quality assertions Exclude records with open user assertions

Exclude all records with unresolved user assertions
Exclude all records with unconfirmed user assertions and so on

Looking at https://doi-test.ala.org.au/doi/48cfd92e-c79d-4785-8c15-f29c13838a31

Also, "Authors" should probably not be "ALA", we are not technically authors of the data, is this a DOI requirement? It doesn't send a good message in the UI.

Also, the Datasets list lists Data Resource names, but also all of the consumers (institutions, collections, data provider) records making the count look bad. Limit these to just the data resources (in this example, 4 out of 16)

The license field could be aggregated, it repeats the license for all 4 datasets which is the same, looks a bit iffy

adam-collins commented 1 year ago

I have changed the DQ section to list the filter's description and the actual filter sent to our services.
Authors is the author of the DOI, not the data. It a mandatory DOI field. I will exclude it from the page.
Only the 3 unique licence values are shown. This can be confirmed by looking at the licence field in the datasets table. If only data resources are shown, every record in the datasets table should have a licence value. Because this is duplication of the licence field, might I suggest removing the licence field?

adam-collins commented 1 year ago

https://github.com/AtlasOfLivingAustralia/doi-service/tree/biocache-doi-view

adam-collins commented 1 year ago

This update is now on doi-test for review.