AtlasOfLivingAustralia / galah-R

Query living atlases from R
https://galah.ala.org.au
39 stars 3 forks source link

Revise syntax for improved compatibility with `dplyr` #101

Closed mjwestgate closed 2 years ago

mjwestgate commented 2 years ago

We've recently received feedback that the use of select_ prefix is confusing, because we use it for choosing both rows and columns, whereas it is more common (e.g. in dplyr, SQL) for filter to refer to rows and select to refer to columns. It's also inconsistent to use NSE in select_filters but not in other functions.

Proposed solution is to use galah_ prefix, followed by a dplyr equivalent suffix, e.g.

daxkellie commented 2 years ago

After discussion, we have decided to change select_locations to galah_geolocate. This change is consistent with the galah_ prefix solution because: