Closed mjwestgate closed 2 years ago
After discussion, we have decided to change select_locations
to galah_geolocate
. This change is consistent with the galah_
prefix solution because:
filter
, select
, group_by
)galah_filter
, which can also filter by broad locations like states/territories.
We've recently received feedback that the use of
select_
prefix is confusing, because we use it for choosing both rows and columns, whereas it is more common (e.g. indplyr
,SQL
) forfilter
to refer to rows andselect
to refer to columns. It's also inconsistent to use NSE inselect_filters
but not in other functions.Proposed solution is to use
galah_
prefix, followed by adplyr
equivalent suffix, e.g.galah_filter
for rowsgalah_select
for columnsgalah_group_by
to pass toala_counts