Closed mjwestgate closed 1 year ago
Proposed name change to something more informative, e.g. galah_quality_profile
A decision was made after discussion to make the name galah_apply_profile()
to keep the verbing language consistent for galah_
functions (e.g., select
,filter
, group_by
). Name might require revisiting in the future
Currently, users set a profile as an optional argument within
galah_filter
. This is weird for a few reasons:tibble
; instead the profile name is added as an attribute, which is not standard behavior for any othergalah_
functionshow_all_profiles
), but no correspondinggalah_
functiongalah_filter
is awkward because it doesn't use NSE. In practice, this results in combining calls that use=
and==
within the same function (e.g.galah_filter(year == 2020, profile = "ALA")
), which is confusingAlternate behaviour would be to allow piping of profiles specifically through its' own function, such as: