Closed mjwestgate closed 1 year ago
8c895c64ae1c2ddd68cb416a70e68cbb3855074a cleans up galah_config
to be more consistent with the above recommendations, while still retaining the basic function structure
Closing this as galah_config
now has improved behaviour and a new print
method
From a UX perspective,
galah_config()
has a few problems:galah_
functions can be piped and use NSE, butgalah_config
doesn'tgalah_config
controls a lot of functionality that isn't obviously relatedOne potential way to resolve this would be to split this into different functions for different purposes (proposed names in parentheses):
{galah}
functions, particularly regarding checks and verbosity (perhapsconfig_session()
?)atlas_choose()
,switch_atlas()
orconfig_atlas()
) - this could support NSE, but perhaps not piping, as changing atlases mid-pipe could lead to unexpected behaviour (hence whygalah_atlas()
is not a proposed function name)galah_login()
orconfig_login()
). This should cache login information for later queries. If thegalah_
prefix is used then it should be pipe-able to match othergalah_
functions, and may need to use NSE as well.Note as well that current storage behaviour for information on different atlases is inadequate; future implementations need to be able to store information on the atlas name, region, name service source and architectural source.
show_all_atlases
also needs to be expanded to support this information.[The above are notes from meeting of galah dev team 2022-05-09]