AtlasOfLivingAustralia / galah-R

Query living atlases from R
https://galah.ala.org.au
38 stars 3 forks source link

`search_field_values()` not displaying correct deprecated warning #167

Closed daxkellie closed 9 months ago

daxkellie commented 1 year ago

search_field_values() - superseded by show_values() - should still continue to work correctly over the typical deprecation process and display a deprecation message.

Instead, it errors and provides an unhelpful error message

library(galah)

search_field_values("cl22")
#> Warning: We didn't detect a valid query.
#> ℹ Try entering text to search for matching values.
#> Error in grepl(query, tolower(field_text$category)): argument "query" is missing, with no default

Created on 2022-11-02 with reprex v2.0.2

daxkellie commented 9 months ago

search_field_values() now fully deprecated in galah 2.0.0 in favour of:

show_all(fields, "cl22") |> show_values()