AtlasOfLivingAustralia / galah-R

Query living atlases from R
https://galah.ala.org.au
38 stars 3 forks source link

`show_values` not returning content with >400 rows #170

Closed mjwestgate closed 1 year ago

mjwestgate commented 1 year ago

With changes to the ALA APIs, we are now limited to 400 rows, even for large datasets. For example, the GRIIS list stored by ALA here has 2984 rows, but:

search_all(lists, "dr17242") |> show_values() |> nrow()
• Showing values for 'dr17242'.
[1] 400

To solve this, we can either add a higher max value to the API call, or paginate.

Sub-issue: should the df arg in show_values be labelled .data for consistency with other functions?

mjwestgate commented 1 year ago

Note: atlas_GET contains pagination code that may duplicate atlas_paginate; check for efficiencies

mjwestgate commented 1 year ago

As of v 1.5.1 this appears fixed, albeit with optional limitation of number of rows via limit argument