Closed matildastevenson closed 2 years ago
Follow-up: This is important because when galah_config(run_checks = TRUE)
is set, every call to select_filters
or select_columns
(and a few others, like ala_counts
) has to run search_fields
first. This is very slow for something that would otherwise simply return some parsed text.
Proposed solution is:
valid_fields
slot to galah_config
which is a length-zero vector by default (i.e. c()
)validate_fields()
and validate_cols
into a single function (e.g. validate_fields()
)galah_config(valid_fields)
as emptyvalidate_fields
, update valid_fields
galah_config
from saving/loading information from valid_fields
to profile (i.e. no long-term storage)This should work within a session without slowing package loading, while also preventing long-term storage
Could use
memoise
to do this, or could cache in the same way as downloaded data, but this would preserve results between sessions.