AtlasOfLivingAustralia / galah-R

Query living atlases from R
https://galah.ala.org.au
39 stars 3 forks source link

`search_taxonomy` fails to search 'below' informal nodes #86

Closed mjwestgate closed 3 years ago

mjwestgate commented 3 years ago

In version 1.3.0, the following code fails to detect a lot of taxa, apparently because it stops searching at nodes labeled informal or unranked. This leads to some very visible problems, e.g.

search_taxonomy("Animalia", down_to = "class")

....fails to return any of the vertebrate classes, because they are all listed under the informal rank Gnathostomata. This appears to occur because the recursive function inside search_taxonomy (level_down()) checks against find_ranks()before proceeding, and informal is not listed in find_ranks. Suggest allowing level_down to recognise informal nodes.

mjwestgate commented 3 years ago

This has been addressed with the following steps: