AtlasOfLivingAustralia / la-pipelines

Living Atlas Pipelines extensions
3 stars 4 forks source link

Spatial portal - Taxon frequency error message #323

Open RobinaSanderson opened 3 years ago

RobinaSanderson commented 3 years ago

Steps to recreate:

  1. Add to Map - species - Red morwong limited to Australia
  2. Add to Map - species - Little penguin limited to Australia saved session: https://nectar-spatial-test.ala.org.au/?ss=1619763158898

3. Tools - Taxon frequency

  1. select red morwong as the primary taxon
  2. select Little penguin as the secondary taxon

Resulting error message reads: failed (id:59613): Ambiguous method overloading for method java.lang.Double#div. Cannot resolve which method to invoke for [null] due to overlapping prototypes between: [class java.lang.Character] [class java.lang.Number] running (id:59613)

Note: If you select little penguin as the primary taxon and red morwong as the background, the tool will work. So I'm not entirely sure if this is an actual issue as I don't really know what this tool is doing...

djtfmartin commented 3 years ago

I think is fixed now on quoll. I suspect this wasn't working because of missing Taxon lookup services that we have now enabled.

Screen Shot 2021-04-30 at 2 11 00 pm

@RobinaSanderson could verify ?

RobinaSanderson commented 3 years ago

Thanks @djtfmartin - It worked when I used Red Morwong as the primary and little penguin as the secondary, but when I ran it again with the species swapped I got the error message: image

Maybe the issue is running the taxon frequency tool twice in a row without any time in between? I'll try with some other species... So I did 5 separate taxon frequency checks in a row with various combinations of Chenonetta jubata, Platalea (Platibis) flavipes, Anseranas semipalmata - these all worked without getting the error.

Then after a 5 minute break I tried Dendrelaphis punctulatus (Australia) and Oxyuranus scutellatus (World) and got the error again. So this appears to be pretty erratic.

I can't see a recognisable pattern for when I get the error, but it works out to be about one in 5 times I run the tool. I've tried combinations of species with low numbers of occurrences, high numbers of occurrences, restricted to just Australia or covering the world. Happy to check other combinations if you have ideas.

djtfmartin commented 3 years ago

This can be re-tested.

RobinaSanderson commented 3 years ago

Hi @djtfmartin - I got the error again. image

Saved session here: https://nectar-spatial-test.ala.org.au?ss=1621379338339

What I did:

  1. created bounding box area
  2. Ran the Taxon frequency tool using the My rectangle area with Red Morwong as primary and Little Penguin as secondary - that worked
  3. Immediately re-ran the tool using the My rectangle area with Little Penguin as the primary and Red Morwong as the secondary - got the error
adam-collins commented 3 years ago

Issue also appears in production.

There was an assumption that secondary occurrences is a subset of the primary occurrences. While this was the original intention for the tool there is no need to make this assumption.

RobinaSanderson commented 3 years ago

Maybe using a subset that makes more sense to a "real" user, @adam-collins. If that's how it should be used, we could put that into the user documentation instead?