AtlasOfLivingAustralia / la-pipelines

Living Atlas Pipelines extensions
3 stars 4 forks source link

min depth and max depth terms not dwc standard #469

Closed peggynewman closed 3 years ago

peggynewman commented 3 years ago

The terms min depth and max depth have no units of measurement apparent on the record page

The correct DwC terms are http://rs.tdwg.org/dwc/terms/minimumDepthInMeters http://rs.tdwg.org/dwc/terms/maximumDepthInMeters

See whale record for example: https://biocache.ala.org.au/occurrences/71996a3f-60bc-4f34-b1cb-63f615503610

It's clear from https://biocache.ala.org.au/fields?filter=depth that the fields are in meters Also there aren't any crazy other measurement values in the field (min at least)

Can we update the labels?

djtfmartin commented 3 years ago

Yes, this looks like something to fix in i18n properties.

javier-molina commented 3 years ago

@peggynewman What are the proposed labels?

peggynewman commented 3 years ago

Maximum depth in metres Minimum depth in metres

djtfmartin commented 3 years ago

Fixed in test https://biocache-test.ala.org.au/occurrences/71996a3f-60bc-4f34-b1cb-63f615503610

qifeng-bai commented 3 years ago

Tested