AtlasOfLivingAustralia / layers-service

Spatial layers - this repo for issues/doc only, not code
3 stars 4 forks source link

Fix missing objects: 5 objects in layer nrm2017_qld2019 (cl10947) are present in geoserver but not in the spatial portal api #118

Closed cofiem closed 4 years ago

cofiem commented 4 years ago

Hello,

I maintain an instance of biocollect and ecodata which uses the ALA's spatial server.

I'm trying to resolve an issue with missing objects in the layer nrm2017_qld2019 (cl10947). The objects all show up on the ALA's spatial portal, but in biocollect there are some objects missing on the 'globe' dropdown in the maps when creating or editing a project or site.

I've looked into this, and the issue seems to be that the geoserver contains the 61 expected objects, but the spatial server api is missing 5 objects. Biocollect uses the spatial service api, so the items are missing in biocollect.

I've compared these endpoints:

The missing items in the two spatial server API, but present in the geoserver API are:

I've compared this to the older NRM region nrm_regions_2017 (cl10930). It has 63 items in all the three endpoints, which is what I expect.

Could you please look into this? I think the three APIs should return the same results, which should include the missing 5 items. There should be 61 objects in total.

nickdos commented 4 years ago

@adam-collins could you take a look at this please?

ansell commented 4 years ago

For reference, biocache is showing the expected 61 objects in facet queries for cl10947:

https://biocache-ws.ala.org.au/ws/occurrences/facets/download?q=cl10947%3A*&facets=cl10947&count=true&lookup=true
adam-collins commented 4 years ago

61 objects now in

The problem was that these areas had self intersecting polygons and were excluded by the validity test.

cofiem commented 4 years ago

I've tested this out, and it looks to be fixed. Thanks very much! Is there any chance of the areas being excluded again in the future?

adam-collins commented 4 years ago

I am currently reviewing the process for this issue.

This issue will remain open until the underlying issue is resolved.

adam-collins commented 4 years ago

This will not be an issue for future layers.

The CAPAD 2010 Terrestrial was the only other layer with an issue. It is now consistent.