AtlasOfLivingAustralia / logger-service

Atlas event logging
https://logger.ala.org.au
1 stars 8 forks source link

Fix links on home page #22

Closed nickdos closed 3 years ago

nickdos commented 3 years ago

Screen Shot 2021-07-05 at 12 05 57 pm

Example JSON queries are for entityUid=in4 (example for Australian Museum) which is not indicated in the HTML content as shown above. I suggest removing this and all entityUid data attributes from example URLs.

Another link requires update: User category breakdown by month (all records) csv link on test is missing entityUid=in4

Rita-C commented 3 years ago

Code reviewed and tested on logger-test Screen Shot 2021-07-05 at 12 16 22 pm

nickdos commented 3 years ago

image

Reason breakdown is for all entities but source breakdown is for &entityUid=in4 - I think most users will miss this nuanced difference, so thinking we should either make them use the same params, or create a second line for the reason breakdown that shows records for in4 so users can compare output from the source breakdown. Either way, the link text should provide a hint that it is either all entityUid values or for in4 (provide name of this institution).

Rita-C commented 3 years ago

Screen Shot 2021-08-09 at 1 59 15 pm

Descriptions updated

nickdos commented 3 years ago

LGTM