search

AtlasOfLivingAustralia / logger-service

Atlas event logging
https://logger.ala.org.au
1 stars 8 forks source link

getReasonBroken for all fails #63

Open qifeng-bai opened 10 months ago

qifeng-bai commented 10 months ago

In code: https://github.com/AtlasOfLivingAustralia/logger-service/blame/ea01a4d35f2c031ba1850004a3e04d13c2dfbe63/grails-app/controllers/au/org/ala/logger/LoggerController.groovy#L263

When you choose 'all', it will pass 'null' value to 'from' and 'to' (edited)

However, in line: https://github.com/AtlasOfLivingAustralia/logger-service/blob/develop/grails-app/services/au/org/ala/logger/LoggerService.groovy#L398C3-L399C118

It assert: assert fromDate && toDate || !fromDate && !toDate, "Must supply both a dateFrom and dateTo string or neither"

I guess that the reason it fails