search

AtlasOfLivingAustralia / profile-hub

Profiles front end application
http://www.ausflora.org.au/
0 stars 3 forks source link

Refactor image handling for public and private images #322

Open m-r-c opened 8 years ago

m-r-c commented 8 years ago

To abstract the differences between remote (images in images.ala.org.au), private and staged images.

At the moment, there are a number of places that need to know where to go to find image files and metadata - e.g. the ui when displaying the image, the image details popup, several points within the ImageService, etc. There are also a number of different image urls (thumbnail, original, metadata, images.ala.org.au, etc).

It should be possible to expose a clean interface on the ImageController for all images, local and 'remote', and have the controller (or the ImageService) direct the calls to the appropriate source. This will become even more important if/when support for external image sources such as Flickr are introduced.

As an example, markupHtml.js, which replaces embedded images in attributes with an angular directive to open the zoomable image viewer, has to deal with 3 image URL formats.

The current implementation is difficult to extend.

RobinaSanderson commented 7 years ago

Hi @sbearcsiro This is one of those stories we need to know if this still needs to be done.