search

AtlasOfLivingAustralia / regions

Regions front end web application
https://regions.ala.org.au
1 stars 16 forks source link

Fix timelapse chart throwing an error #106

Closed StefanVanDyck closed 2 weeks ago

StefanVanDyck commented 2 months ago

When trying to play the timelapse chart in regions we were getting an error dialog box. This was caused by the SOLR range query containing unencoded square brackets. Simply making sure that part of the query is also encoded should fix things.

StefanVanDyck commented 2 months ago

I think with the last commit, I finally got most of the places that were missing urlencoding for the request parameters.

adam-collins commented 1 month ago

I failed to reproduce the url encode errors. More details to reproduce are required.

I did find various time control issues, see #107.

StefanVanDyck commented 1 month ago

Thanks for having a look @adam-collins .

I suspect the reason I was having issues is that I am using AWS ALB as reverse proxy. And that things like nginx and grails itself actually have no issue with square brackets in the URI.

According to the standard square brackets are not supported however and including this "fix" might help other people that encounter similar issues.

I'll make sure to merge the improvements you made on #107 into this branch.

Please tell me f you would like me to make any other changes or add some testing before accepting the PR.