Clicking "Next" before closing polygon breaks New area process

AtlasOfLivingAustralia / spatial-hub

New spatial portal front end using AngularJS

https://spatial.ala.org.au/

7 stars 16 forks source link

Clicking "Next" before closing polygon breaks New area process #343

Closed timhicks-ala closed 1 year ago

timhicks-ala commented 4 years ago

Add to map -> Area -> Draw polygon -> Next
Start drawing a polygon, but do not click the first point again - do not complete the polygon
It is possible to click "Next" and have a progress bar appear, but it will never complete as the polygon is not complete and the WKT text has not been generated.

Solution: Disable the "Next" button on the "Create area" dialog until the polygon is completely drawn and closed.

SP open polygon

nickdos commented 3 years ago

@adam-collins add commit link

qifeng-bai commented 3 years ago

Draw points, circus or other 'drawing on map' will cause this issue. Mainly because :
ng-disabled="(intersect.value.length == 0 && selectedArea.wkt.length == 0)"

Either Intersect or selectedArea will be null, so it always return false

PR: https://github.com/AtlasOfLivingAustralia/spatial-hub/pull/360

NOTE: not sure why this PR contains another PR of QID