search

AtlasOfLivingAustralia / spatial-hub

New spatial portal front end using AngularJS
https://spatial.ala.org.au/
7 stars 16 forks source link

ALA Favicon is not being included #384

Closed nickdos closed 1 year ago

nickdos commented 3 years ago

SP is not including any href value for the favicon link tag, e.g. ALA Biocache site shows:

<!-- Favicon -->
<link href="https://www.ala.org.au/app/uploads/2019/01/cropped-favicon-32x32.png" rel="shortcut icon"  type="image/x-icon"/>

SP is showing:


<!-- Favicon -->
<link href="" rel="shortcut icon" type="image/x-icon"/>
qifeng-bai commented 3 years ago

Changes were made on both Spatial Hub and Spatial Service: https://github.com/AtlasOfLivingAustralia/spatial-hub/commit/d0bfdf8108bbd1e5118989d7e4507a26b94717dd https://github.com/AtlasOfLivingAustralia/spatial-service/commit/aa49fc2252bbf1a3bc46422e27add2b4ceafbeff

nickdos commented 3 years ago

See it on test now ✅