search

AtlasOfLivingAustralia / spatial-hub

New spatial portal front end using AngularJS
https://spatial.ala.org.au/
7 stars 16 forks source link

Previous user saved sessions are missing in prod #388

Closed nickdos closed 1 year ago

nickdos commented 3 years ago

After a recent change, viewing the saved sessions (using the "load" menu item) on SP shows older entries without a link (URL column). Therefore users are not able to reload previously saved sessions (saved sessions created since last version are OK). See screenshot:

image

Adam thought the last release had a change relating to this function. Although we did delete some dirs in /data so can't completely rule this out. See Slack comment.

qifeng-bai commented 3 years ago

It is designed to do so. URL in last version was calculated on runtime, Adam and I found there are some issues on this solution. Restoring session does not work properly intermittently, reported in https://github.com/AtlasOfLivingAustralia/spatial-hub/issues/245

In current version, URL is generated and stored when we save a session.

@nickdos we can support calculating the url on fly as well, however, this url is not guaranteed to work all the time.

nickdos commented 3 years ago

@qifeng-bai - if you can support the old way for "legacy" saved data, this is preferable.

qifeng-bai commented 3 years ago

PR: https://github.com/AtlasOfLivingAustralia/spatial-hub/commit/c9e78ac4d29befb6f51dd1087b6826b2e436db6d

nickdos commented 3 years ago

Code reviewed ✅

nickdos commented 3 years ago

Can't test actual fix as my account on test did not have any old saved data. I did test adding new data and it works as expected.