AtlasOfLivingAustralia / spatial-hub

New spatial portal front end using AngularJS
https://spatial.ala.org.au/
7 stars 16 forks source link

Spatial options not displayed on AOO/EOO wizard UI #403

Closed nickdos closed 1 year ago

nickdos commented 3 years ago

When running an AOO/EOO calculation, the modal shows the following:

image

The warning line Minimum one spatially related option is required! See this support article for more information should not be displayed here, as there are no spatially related options on this form.

Update: the spatial options are not being displayed above the warning for some reason. Seems to be for URLs that come via biocache, e.g. https://spatial.ala.org.au/?q=lsid:https:%2F%2Fid.biodiversity.org.au%2Fnode%2Fapni%2F2920976&disableAllQualityFilters=true

nickdos commented 3 years ago

Seems to occur when using a link from biocache, such as

https://spatial.ala.org.au/?q=lsid:https:%2F%2Fid.biodiversity.org.au%2Fnode%2Fapni%2F2920976&disableAllQualityFilters=true

When using new session, the spatial options are displayed.

qifeng-bai commented 3 years ago

Fixed. One line code change: https://github.com/AtlasOfLivingAustralia/spatial-hub/commit/2ed9c4fc18d51a48970f6bbe6d4671a97f9ece3f

nickdos commented 3 years ago

Thanks @qifeng-bai - I just looked at change and its trivial so code review done ✅