Dialog hangs when adding a species with no occurrences in an area - Githubissues

AtlasOfLivingAustralia / spatial-hub

New spatial portal front end using AngularJS

https://spatial.ala.org.au/

7 stars 16 forks source link

Dialog hangs when adding a species with no occurrences in an area #415

Closed timhicks-ala closed 1 year ago

timhicks-ala commented 3 years ago

Add an area in SP (eg. a small rectangle in SA)
Add a species to that area that has no occurrences in the area (eg. Casuarius casuarius)
Dialog shows "No occurrences mapped for this layer and applied filters." as expected.

Click OK on that box. The "Add a species layer to the map" box remains, with an unavailable "Next >" button. You can only click Cancel on this, but you shouldn't need to if adding a species has failed.

"Casuarius casuarius (My Rectangle)" is still added to the list on the left as a species, despite containing zero occurrences.

Expected behaviour:

Where adding a species to an area fails due to no occurrences being found, all dialog boxes should be dismissed when clicking "OK" on the "No occurrences mapped..." box.
An empty species entry should not be added to Spatial if no occurrences were found.

Tasilee commented 3 years ago

Fully agree. I have had the same issue a number of times.