search

AtlasOfLivingAustralia / spatial-hub

New spatial portal front end using AngularJS
https://spatial.ala.org.au/
7 stars 16 forks source link

Fix i18n issues #433

Closed qifeng-bai closed 1 year ago

qifeng-bai commented 2 years ago

Tasks:

1, Use the default English messages if messages are not available for a target language 2, Switch languages based on locale

Link to PR created by @vjrj https://github.com/AtlasOfLivingAustralia/spatial-hub/pull/428#pullrequestreview-792727829

TEST:

https://spatial-test.ala.org.au/?lang=ES https://spatial-test.ala.org.au/?lang=DE

vjrj commented 2 years ago

The PR is from Georg @biodivAtlasAT (Austria) thanks @qifeng-bai I was trying to review it only.

qifeng-bai commented 2 years ago

@vjrj I have fixed up i18n issues and deployed on https://spatial-test.ala.org.au

You can switch languages by clicking the language button on the top left

vjrj commented 2 years ago

Thanks indeed @qifeng-bai !

biodivAtlasAT commented 2 years ago

Thank you!

Von: vjrj @.> Gesendet: Donnerstag, 3. März 2022 08:41 An: AtlasOfLivingAustralia/spatial-hub @.> Cc: Georg Neubauer @.>; Mention @.> Betreff: Re: [AtlasOfLivingAustralia/spatial-hub] Fix i18n issues (Issue #433)

Thanks indeed @qifeng-baihttps://github.com/qifeng-bai !

— Reply to this email directly, view it on GitHubhttps://github.com/AtlasOfLivingAustralia/spatial-hub/issues/433#issuecomment-1057760500, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANPMCUG6ITUPWIIKDXYZBVLU6BUKPANCNFSM5OWLEV6A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

patkyn commented 2 years ago

Tested and pass