AtlasOfLivingAustralia / specieslist-webapp

Species lists and traits tool
https://lists.ala.org.au
Mozilla Public License 2.0
6 stars 21 forks source link

guid are not displayed as URLs #127

Open javier-molina opened 4 years ago

javier-molina commented 4 years ago

A species list downloaded include a guid that has a URL format. Currently if this list is uploaded back it will display guid displaying the html markup for a link.

Steps to reproduce

Expected

Expected

This file can be used for testing

'A_Genome'_Oryza_species.csv.txt

This is a sample screenshot

Screen Shot 2019-11-27 at 10 18 37 am

Additional consideration What sanitation needs to be performed: only urls of the form "http://id.biodiversity.org.au/node/apni...", "https://bie*.ala.org.au/species/..."?

sughics commented 2 years ago

guid URL display issue has been addressed in PR #208

PR #208 also includes fixes for related issue(s) mentioned below: Some lists seem to have duplicate columns and the app seems to allow duplicate keys for species list item. I'm unsure if in the example below, the additional columns were intentionally added by test user during upload or if its the result of a faulty upload e.g. https://lists-test.ala.org.au/speciesListItem/list/drt1574809264463

When a list like above is downloaded, the downloaded csv file also includes duplicate columns and is a lot more obvious: Oryza_v3.5.1_testing (2).csv In the example above, the guid, Supplied Name and family fields are duplicated. When this file is uploaded back to the app, in addition to the duplicated fields being persisted, the row parser parses the duplicate guid column which already includes a parsed url . Screen Shot 2022-05-24 at 4 44 35 pm