AtlasOfLivingAustralia / specieslist-webapp

Species lists and traits tool
https://lists.ala.org.au
Mozilla Public License 2.0
6 stars 21 forks source link

Deleting a taxon from list deleted all contents from fq column (Editing an fq has also resulted in deleted fq column content too) #311

Closed turley85 closed 1 month ago

turley85 commented 1 month ago

I was reviewing this list (https://lists.ala.org.au/speciesListItem/list/dr27347) to amend the -taxon query. I found a taxon that was erroneously including in the list. As such, I clicked the delete button for that taxon.

Upon the list reloading, all contents from the fq column had been deleted.

turley85 commented 1 month ago

Also, this list just the fq was edited to add the -taxon query to the genus. Now all other fq data is deleted. https://lists.ala.org.au/speciesListItem/list/dr27361?&sort=rawScientificName&max=100&order=asc

turley85 commented 1 month ago

fq column also partially deleted on this list. https://lists.ala.org.au/speciesListItem/list/dr27362

This list was also edited to add a -taxon_name

kylie-m commented 1 month ago

In replicating this issue, I've had slightly different results. In this case, the entire fq column has moved, from the far right of the display, to the middle of columns (screenshot below)

Steps to generate the issue:

  1. go to https://lists.ala.org.au/speciesListItem/list/dr27336
  2. I started with 4 taxa on the list. The top one had cl927:* for fq field
  3. Added placeholder string text to another taxa on the list. save, refreshed page
  4. Removed cl927 from fq of first taxa. save, refreshed page
  5. check page, fq column missing from end of columns, now in middle

Same thing happened with https://lists.ala.org.au/speciesListItem/list/dr27158

kylie-m commented 1 month ago

Also tried to replicate the issue on https://lists.ala.org.au/speciesListItem/list/dr27372, this list seemed to be error free, as i began with content in all 3 fq fields. I have deleted fq content for one taxa, refreshed, repeated, and the fq content for one taxa remains

kylie-m commented 1 month ago

screenshot

Screenshot 2024-07-23 at 2 57 24 pm

kylie-m commented 1 month ago

The workaround of reloading a list has been discussed - so in the meantime, @turley85 is reloading lists to ensure testing can proceed

adam-collins commented 1 month ago

Item to test, confirm that the now undeleted item does not appear in the list export e.g. https://lists-test.ala.org.au/ws/speciesListItems/dr22791?includeKVP=true

kylie-m commented 1 month ago

I gave this a spin on test and it is working ok for me. @turley85 could you test it too and see how it goes using a list on test ? My steps are below for reference:

  1. edit fq column on a list, save, reload
  2. check the fq column remains visible, contents update correctly for the taxa you edited, and contents of fq column for other taxa remain unchanged
  3. repeat 1-2 times
  4. download the species list csv and check - fq column should be there, and contents should be correct for each row
kylie-m commented 1 month ago

Also confirming that editing the fq column updates the list export - e.g URL: https://lists-test.ala.org.au/ws/speciesListItems/dr22791?includeKVP=true

turley85 commented 1 month ago

I just had a look at lists in test and it appears to be working as intended there.