AtlasOfLivingAustralia / travis-build-configuration

travis-ci.org build configuration files shared/re-used among ALA projects
5 stars 8 forks source link

Do NOT use the github repository name/string for constructing the grails plugin name #2

Closed mbohun closed 9 years ago

mbohun commented 9 years ago

Thanks to Alan @linaizhong for pointing this one out.

generate-github-travis-build-summary-with-grails.sh uses github repository name when constructing the grails plugin class name; that works OK only when the github repository name AND the app.name in application.properties are the same, for example:

github repo name app.name generated grails plugin name
ala-web-theme ala-web-theme AlaWebThemeGrailsPlugin.groovy
collectory-plugin collectory CollectoryPluginGrailsPlugin.groovy

Depending on in where/how the BASH script affected by this BUG was used it would build a wrong grails plugin file name (for example: CollectoryPluginGrailsPlugin.groovy) and fail all subsequent processing, like extracting the version number from the grails plugin file, etc.)

Solution is obvious: do not use github repository name; use the value extracted from app.name field in application.properties when building/creating the grails plugin file name; because that works always, regardless on the github repository name.

mbohun commented 9 years ago

fixed: a7e0e704987ace0fe4d89e72b241838db1fa2054