Update call of get_token() in class Power_Bi

AtlasPublicPolicy / power-bi-embedded

Use Power BI Embedded to embed dashboards, reports, report visuals, Q&A, and tiles in your WordPress website.

GNU General Public License v3.0

49 stars 34 forks source link

Update call of get_token() in class Power_Bi #19

Closed jangabler closed 1 year ago

jangabler commented 4 years ago

Power_Bi_Oauth's non-static function get_token() is used as a static function in Power_Bi's get_powerbi_access_token().

https://github.com/atlaspolicy/power-bi-embedded/blob/4a7c9f06fc8378f8f65ba0ebd611d48961210ae6/includes/class-power-bi.php#L91-L94

pbenzoni commented 4 years ago

@atlaspolicy, I tried this change out with the atlas test site and it not only does it not conflict with anything, it helped solve a problem I was having with the service principal based embedding I was working on. +1 from me, should be pulled into next release. Thanks, @jangabler!

timnolte commented 3 years ago

Is this PR going to get merged in? Seems like there is not much support or ongoing development of this plugin. I was considering using this plugin but if not even PRs are being reviewed in merged in to release features, and no new releases for a year, it seems like this plugin may be abandoned?

jangabler commented 1 year ago

PR is obsolete, this issue was fixed in 1c4e5f42f2a4ae68b102c72b02c6d56983ff415f.