search

AtlassianPS / JiraPS

PowerShell module to interact with Atlassian JIRA
https://AtlassianPS.org/module/JiraPS
MIT License
323 stars 131 forks source link

New-JiraIssue uses magic $ConfigFile variable #219

Closed KevinMarquette closed 6 years ago

KevinMarquette commented 6 years ago

https://github.com/AtlassianPS/JiraPS/blob/1cdc0cbf08ef9b8056ceef839985d78768b4cc0e/JiraPS/Public/New-JiraIssue.ps1#L83

As I was debugging another issue and $ConfigFile was $null in my debugging session. I don't know if that was just an artifact of VSCode, but this variable looks out of place. It is not defined in this function but is being used within it.

If I had to guess, $ConfigFile was a parameter but was removed. I think you handle the null value down the stack, so this is just more of a code cleanup thing.

lipkau commented 6 years ago

Hey.

Yes; it was a parameter. It has been removed a long time ago... This was already "fixed" in pr #215 and will be merged for the next minor release

KevinMarquette commented 6 years ago

Thank you. Sorry, I should have checked the other branches.

lipkau commented 6 years ago

No sweat. But I am glad to hear you are using this module :-)