feature/issue 314 - Ability to add worklog during issue transition

AtlassianPS / JiraPS

PowerShell module to interact with Atlassian JIRA

https://AtlassianPS.org/module/JiraPS

MIT License

323 stars 131 forks source link

feature/issue 314 - Ability to add worklog during issue transition #343

Open alexsuslin opened 5 years ago

alexsuslin commented 5 years ago

Description

Invoke-JiraIssueTransition now have additional parameter -TimeSpent where user can add worklog time he is working on this issue

Motivation and Context

I would like to resolve the issue and specify worklog time

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] I have added Pester Tests that describe what my changes should do.
[x] I have updated the documentation accordingly.

alexsuslin commented 5 years ago

We can discuss the behavior of SpentTime as [string] vs [TimeSpan] here, all the pros and cons

lipkau commented 5 years ago

hey @alexsuslin . Sorry, I forgot about this PR.

We can change the behavior, but then I would plea to change it in the other places as well. And this would be a breaking change.

So I would suggest, to implement it as [TimeSpan] and merge it with this PR as a new minor version. And submit a different PR where we change it to [String] and it will be merged with the next major version. What do you think?

lipkau commented 5 years ago

@alexsuslin ?

lipkau commented 4 years ago

@alexsuslin : can you please update the pull request?