Closed mirrorgleam closed 5 years ago
Could you please submit a pull request to this issue?
I'm not familiar with pull requests but I'll look it up and try to figure out what I need to do.
Thank you, @mirrorgleam . Here are the instructions on how to submit a Pull Request: https://atlassianps.org/docs/Contributing/#how-to-submit-code-changes
of course I would gladly support you with it :-)
Just submitted it. I hope it's up to standards. I just submitted one for the Invoke-JiraIssueTransition, should I also submit one for the JiraPS.psm1 file?
And on further review I now see that isn't necessary. Clever coding on that file. I've learned something new about PS. Also, thanks for building this module. It's been extremely helpful these past few months.
I do not see your PR yet. https://github.com/AtlassianPS/JiraPS/pulls
can you post the link to the PR you created?
I see your commit: https://github.com/mirrorgleam/JiraPS/commit/0a201610313d582d6effb2eb7082b2c21ae27a63
By clicking this button, you create the PR:
This is what you should get: https://github.com/AtlassianPS/JiraPS/compare/master...mirrorgleam:mirrorgleam-patch-1?expand=1
This is what I get when I click that.
AH THINK I FOUND IT :D
It looks like it's in your pull requests now
Description
If JIRA has usernames such as "jsmith", "jsmithy", "jsmith1", "jsmithson" and you are trying to assign the ticket to "jsmith" it will fail because the assignee field needs a string but this function is returning an array of strings.
Steps To Reproduce
Expected behavior
Ticket will be assigned to the user in $userDetails
Possible Solution
My Fix: Modified JiraPS.psm1 line 2964:
if ($assigneeObj = Get-JiraUser -InputObject $Assignee -Credential $Credentials) {
change: added-Exact
flag toGet-JiraUser
functionIn https://github.com/AtlassianPS/JiraPS/blob/master/JiraPS/Public/Invoke-JiraIssueTransition.ps1 line 112